Status: Untriaged Owner: [email protected] Labels: Type-Bug Pri-2 OS-All Area-Misc LayoutTests
New issue 24189 by [email protected]: fast\dom\open-and-close-by-DOM.html is failing http://code.google.com/p/chromium/issues/detail?id=24189 (from http://buganizer/issue?id=753420 ) tc on June 14 2007 17:28 (Assigned) Summary regression: fast\dom\open-and-close-by-DOM.html is failing Component Chrome > Deprecated > Tools > Layout Tests Reporter tc Assignee tc CC chrome-team Type Bug Priority P2 Severity S2 In prod false Notes Adding the navigation controller (window.history) to the test shell has caused this test to start failing. As it turns out, it should have been failing before, but the lack of history was causing it to succeed. In kjs_window.cpp:1817, window.close() is only supposed to work if either the openedByDOM bit is set on the frame or if getHistoryLength() <= 1. Since we had no history, it was closing, but the test is actually supposed to be testing the openedByDOM bit. We're not passing the openedByDOM bit properly because we're passing the frame creation on to our webview delegate (so we can start a new process) and not passing the bit through. Normally the bit is set by FrameLoader::continueLoadAfterNewWindowPolicy(). After talking with Darin, it sounds like we're going to have different rules for whether or not window.close() should work, so I'm just going to disable this test for now. tc on June 14 2007 18:04 (Fixed / Fixed) Notes Disabled in r838. mal on November 02 2007 15:29 (New) Assignee <none> Hotlist Cr__Rel_1.0, WebKit ignored tests Notes I'd like to keep this open until we fix the test and remove it from the ignored list (or decide that we'll never fix it). mal on December 13 2007 11:23 (New) Summary fast\dom\open-and-close-by-DOM.html is failing Notes This doesn't need to be considered a regression anymore. This test is on the ignored list. It should be on the fixable list IMO. eseidel on March 13 2008 17:54 (New) Hotlist Cr__Rel_1.0, WebKit ignored tests, layout_test_failures mal on March 22 2008 14:40 (New) CC chrome-bugs dsiroker on March 31 2008 23:55 (New) Component Chrome > Deprecated > Compatibility > Layout Test Failures ananthak on April 22 2008 14:00 (New) Component Chrome > Deprecated > WebKit eseidel on May 01 2008 13:21 (New) Hotlist WebKit ignored tests, layout_test_failures, Cr__Rel_Future, Cr__Untriaged Notes Not for beta. eseidel on May 01 2008 13:21 (New) Notes To be clear: our behavior is currently intentionally different (as far as I understand). The test can be fixed/tweaked/etc. as part of the great-merge-up after Beta. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
