Comment #1 on issue 24060 by [email protected]: Need to make sure all
ids are unique in decoding bookmarks
http://code.google.com/p/chromium/issues/detail?id=24060
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=28346
------------------------------------------------------------------------
r28346 | [email protected] | 2009-10-07 16:27:01 -0700 (Wed, 07 Oct 2009) |
11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.cc?r1=28346&r2=28345
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_codec.h?r1=28346&r2=28345
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model_unittest.cc?r1=28346&r2=28345
Makes sure bookmark ids are unique on reading from file. If not unique
we reassign them. The particular scenario that can lead to this is
when migrating bookmarks out of the db we never reset the ids of the
newly created nodes, so that we wrote all to the file with ids of
0. I'm not patching that code so that I have coverage of the unit
test, and we'll handle fix up during reading anyway.
BUG=24060
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/268001
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
