Comment #11 on issue 15228 by [email protected]: Alt+Shift+T: Esc flashes find-in bar continuously http://code.google.com/p/chromium/issues/detail?id=15228
The toolbar accessibility traversal is somehow hacky right now as it requires the toolbar to be focused to get the key events, but we don't really want to show it as focused. (see BrowserView::FocusToolbar()). This definitely causes trouble when restoring focus. Actually even pressing Alt-Shit-T then Alt-Tab to deactivate/reactivate the Chrome window does not return the focus properly. I am not sure if this is the reason for the find-bar flashing though. May be what we should do is make the ToolbarView::IsFocusable() return true as suggested by mhm and toolbarview should provide an empty implementation of PaintBorder() so we don't show the view as focused visually. To complement this, it would be good to fix the hack in BrowserView::FocusToolbar(). May be having a method in ToolbarView that initiates the traversal by setting acc_focused_view to the first element, then the focus could be requested normally with RequestFocus() (as then ToolbarView::IsFocusable() would return true). It would be good to have pressing esc exit that mode and return focus to the previously focused view. There is still a problem of when to exit the traversal mode. If we leave the ToolbarView focusable, it will become part of the focus chain. But if we exit the mode, then focus will not be restored properly in the find-box case. Not sure what to do for that just yet. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
