Comment #1 on issue 24881 by [email protected]: You should be able to
use (slightly) bigger icons in browser actions (and maybe page actions)
http://code.google.com/p/chromium/issues/detail?id=24881
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29365
------------------------------------------------------------------------
r29365 | [email protected] | 2009-10-16 18:03:26 -0700 (Fri, 16 Oct 2009) |
20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.h?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=29365&r2=29364
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=29365&r2=29364
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/icon.png
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/manifest.json
Allow slightly larger browser and page action icons.
This allows 19px icons to be able to be used for both
browser and page icons.
I think it looks nicer with the page actions slightly smaller, and that is
what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.
We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.
Also minor layout fix. We were sizing the browser action
buttons 1px too short.
BUG=24881
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should
be 17px for the page action and 19px for the browser action and centered
nicely in the space.
Review URL: http://codereview.chromium.org/286001
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
