Comment #10 on issue 24160 by [email protected]: Crash on quit in DNS
code
http://code.google.com/p/chromium/issues/detail?id=24160
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29371
------------------------------------------------------------------------
r29371 | [email protected] | 2009-10-16 23:05:31 -0700 (Fri, 16 Oct 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/histogram.cc?r1=29371&r2=29370
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/histogram.h?r1=29371&r2=29370
Remove special code fro calculating bucket index in linear histograms
IMO, the original code was a premature optimization, and worse yet, it
had a subtle off by 1 bug due to floating point rounding (which was
identified by ERoman.... Thanks!!).
This CL removes the special code from linear histograms, and relies on
the "standard" binary search approach to locate the correct bucket
when a new sample is processed.
r=eroman
BUG=24160
Review URL: http://codereview.chromium.org/273065
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
