Comment #2 on issue 24398 by [email protected]: chrome_url_overrides  
doesn't work with packed extension
http://code.google.com/p/chromium/issues/detail?id=24398

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=29376

------------------------------------------------------------------------
r29376 | [email protected] | 2009-10-17 06:54:57 -0700 (Sat, 17 Oct  
2009) | 10 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.cc?r1=29376&r2=29375
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.h?r1=29376&r2=29375
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=29376&r2=29375
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=29376&r2=29375
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/override_igoogle
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/override_igoogle/manifest.json
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/override_igoogle/redirect.html

Fix chrome_url_overides to work with packed extensions.
The InitFromValue code was modifying the JSON with some local data which
was then being re-used by the unpacker and sent up to the browser which
caused it to use this temporary local data as if it was the original
manifest source.

BUG=24398
TEST=pack and install override_igoogle extension

Review URL: http://codereview.chromium.org/276074
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to