Comment #7 on issue 24074 by [email protected]: Should implement  
WebFrameLoaderClient::dispatchUnableToImplementPolicy()
http://code.google.com/p/chromium/issues/detail?id=24074

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=29386

------------------------------------------------------------------------
r29386 | [email protected] | 2009-10-18 19:23:34 -0700 (Sun, 18 Oct 2009)  
| 15 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebFrameClient.h?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/empty_webframeclient.h?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.cc?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=29386&r2=29385
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.h?r1=29386&r2=29385

Make LayoutTests/http/tests/misc/redirect-to-external-url.html PASS.

  * Implement WebFrameLoaderClient::dispatchUnableToImplementPolicy()
  * Implement WebFrameLoaderClient::canHandleRequest() so that an
    unkown scheme makes ResourceError.
    - Introduce WebFrameClient::canHandleRequest() to avoid chrome::
      dependency from webkit/glue.
    - Introduce WebFrameClient::cannotShowURLError() to keep
      transparency of WebURLError.
  * Introduce WebFrameClient::unableToImplementPolicyWithError()
    An implmentation in test_shell prints the message same as WebKit.

BUG=24074
TEST=This change enables 1 test.
Review URL: http://codereview.chromium.org/271087
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to