Comment #12 on issue 25000 by [email protected]: Backspace  
causes "back" action when using IME in text input
http://code.google.com/p/chromium/issues/detail?id=25000

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=29388

------------------------------------------------------------------------
r29388 | [email protected] | 2009-10-18 20:13:31 -0700 (Sun, 18 Oct 2009)  
| 8 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ime_input.cc?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ime_input.h?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event.h?r1=29388&r2=29387
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event_mac.mm?r1=29388&r2=29387

Make backspace not go back while IME is active.

Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by  
setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just  
added a bool "skip" to NativeWebKeybordEvent and set it to "true" for  
rawkeydowns while ime is active.

BUG=25000
TEST=Open webpage. Focus text field. Type something, hit backspace. Text  
should be deleted. Focus background, hit backspace. Browser should go back  
one page. Focus text field, start IME (either by going to  
syspref->international->input menu and enabling e.g. "Kotoeri" and then  
selecting this in the top right corner and typing a single "a", or by just  
activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e),  
hit backspace. Browser should not go back but end IME mode.

Review URL: http://codereview.chromium.org/295003
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to