Comment #5 on issue 20507 by [email protected]: non-ASCII encoding in
URLs is incorrect
http://code.google.com/p/chromium/issues/detail?id=20507
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29470
------------------------------------------------------------------------
r29470 | [email protected] | 2009-10-19 15:44:45 -0700 (Mon, 19 Oct 2009)
| 24 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=29470&r2=29469
Pull in googleurl @ r=120 to fix the query part encoding handling (the
patch by Roland Steiner).
What Roland wrote at http://codereview.chromium.org/243028/show
Encoding of the query part of an URL was inconsistent:
If it was part of a larger relative URL, it would get encoded.
However, if the query part was stand-alone, then it would not be encoded.
As indicated by the original layout test referenced in the bug (see below),
this patch changes the code so that the query part is encoded in both cases.
Note, however, that with this patch the layout test will NOT yet fully pass,
since it also handles the fragment part differently.
As the different handling of the fragment part seems to be quite on purpose,
I have not modified the behavior - see the discussion at
http://code.google.com/p/chromium/issues/detail?id=20507 .
BUG=8912,20507
TBR=brettw
Review URL: http://codereview.chromium.org/297010
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
