Comment #6 on issue 25396 by [email protected]: Next/Previous tab
shortcuts (cmd-opt-arrow) go back/forward when content has focus
http://code.google.com/p/chromium/issues/detail?id=25396
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29660
------------------------------------------------------------------------
r29660 | [email protected] | 2009-10-21 10:15:28 -0700 (Wed, 21 Oct 2009)
| 11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm?r1=29660&r2=29659
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h?r1=29660&r2=29659
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm?r1=29660&r2=29659
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc?r1=29660&r2=29659
Fix cmd-opt-left/right.
This surfaced because I moved global shortcut handling before menu dispatch
recently, and global keyboard handling didn't look at the opt button, so it
thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs,
cmd-left/right should move cursor in text box. Focus web background.
cmd-opt-left/right should switch tabs, cmd-left/right should do history
navigation. Focus omnibox. cmd-opt-left/right should still switch tabs,
cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three
places, cmd-opt-1/2 should not do anything.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648
Review URL: http://codereview.chromium.org/313004
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
