Comment #16 on issue 12131 by [email protected]: Implement I18N support for extensions http://code.google.com/p/chromium/issues/detail?id=12131
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29684
------------------------------------------------------------------------
r29684 | [email protected] | 2009-10-21 12:08:23 -0700 (Wed, 21 Oct 2009) |
20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_file_util.cc?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_l10n_util.cc?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_l10n_util.h?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_l10n_util_unittest.cc?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_message_bundle.cc?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_message_bundle.h?r1=29684&r2=29683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_message_bundle_unittest.cc?r1=29684&r2=29683
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en/messages.json
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/_locales/en_US/messages.json?r1=29684&r2=29683
Implementing better fallback algorithm.
Before:
current_locale->default_locale
Now:
current_locale->chain_of_parent_locales->default_locale
If default_locale is de, and current locale en_US, we follow:
en_US -> en -> de
en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow
this kind of fallback.
Developers can implement common locale root with most of the messages (like
en) and put locale specifics in en_GB (color->colour) or en_US. You can
even symlink en and en_US and save on work.
I am planning on fixing loading local resources too, to use this
child->parent fallback.
BUG=12131
Review URL: http://codereview.chromium.org/293037
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
