Comment #4 on issue 25533 by [email protected]: Regression: Bookmark
manager should support Keyboard keys.
http://code.google.com/p/chromium/issues/detail?id=25533
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29854
------------------------------------------------------------------------
r29854 | [email protected] | 2009-10-22 18:02:38 -0700 (Thu, 22 Oct
2009) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_manager_view.cc?r1=29854&r2=29853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_manager_view.h?r1=29854&r2=29853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/task_manager_view.cc?r1=29854&r2=29853
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/table/table_view_observer.h?r1=29854&r2=29853
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/tree/tree_view.cc?r1=29854&r2=29853
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/tree/tree_view.h?r1=29854&r2=29853
The TableViewObserver::OnKeyDown method signature was changed recently and
the bookmark manager view had not been properly updated and was not called
anymore, breaking the keyboard shortcuts.
This was broken in the TaskManager as well.
Also changed the TreeView to use the base::KeyboardCode.
BUG=25533
TEST=Test that the different shortcuts (CTRL-X,CTRL-V, CTRL-C, DELETE,
ENTER...) work in the bookmark manager.
Test that in the TaskManager, pressing ENTER activates the selected
tab.
Review URL: http://codereview.chromium.org/322006
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
