Comment #11 on issue 25227 by [email protected]: Maximized opaque
frame sized beyond the screen bounds.
http://code.google.com/p/chromium/issues/detail?id=25227
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29882
------------------------------------------------------------------------
r29882 | [email protected] | 2009-10-23 00:12:26 -0700 (Fri, 23 Oct 2009) |
2 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/app/gfx/insets.h?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame_win.cc?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame_win.h?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/widget_win.cc?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/widget_win.h?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/window/window_win.cc?r1=29882&r2=29881
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/window/window_win.h?r1=29882&r2=29881
Make sure the RootView is sized to the correct bounds when the opaque frame
is maximized.It seems that now, when an opaque frame is maximized we also
need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know
why, it's just is.I reworked the way Widget allows subclasses to handle
sizing of the RootView... I delegate responsibility for determining the
RootView's bounds to a helper virtual function which BrowserFrameWin
overrides. This seems cleaner to me. I make sure this handling only occurs
when the window is not maximized.http://crbug.com/25227TEST=use to a theme
or switch off glass on vista or use Xp. Maximize the browser window. The
tabs should be entirely visible.
Review URL: http://codereview.chromium.org/304007
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
