Comment #12 on issue 24472 by [email protected]: Implement per-window  
browser action details
http://code.google.com/p/chromium/issues/detail?id=24472

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=29997

------------------------------------------------------------------------
r29997 | [email protected] | 2009-10-23 21:35:08 -0700 (Fri, 23 Oct 2009) |  
13 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.h?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_file_util.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.h?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29997&r2=29996
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action2.cc
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action2.h
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action2_unittest.cc
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29997&r2=29996
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html?r1=29997&r2=29996
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/background.html
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action_tab_specific_state/manifest.json

Refactor BrowserActions, and add support for
tab-specific state.

Future changelists will move Page Actions over to
ExtensionAction2, then replace ExtensionAction and
ExtensionActionState with ExtensionAction2.

Also, fix a bug in setIcon({path:...}) where it
would work only the first time.

BUG=24669,24472

Review URL: http://codereview.chromium.org/306044
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to