Comment #8 on issue 25803 by [email protected]: Browser crash on
startup @ `anonymous namespace'::OnNoMemory()
http://code.google.com/p/chromium/issues/detail?id=25803
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30171
------------------------------------------------------------------------
r30171 | [email protected] | 2009-10-26 23:09:33 -0700 (Mon, 26 Oct 2009) |
15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_model.cc?r1=30171&r2=30170
Fix browser crash on startup.
> chrome.dll!`anonymous namespace'::OnNoMemory() Line 126 C++
chrome.dll!_invalid_parameter_noinfo() Line 99 + 0xc bytes C++
chrome.dll!RefCountedBytes::front() Line 67 + 0x1b bytes C++
chrome.dll!BookmarkModel::OnFavIconDataAvailable(int handle=8, bool
know_favicon=true, scoped_refptr<RefCountedBytes> data={...}, bool
expired=true, GURL icon_url={...}) Line 652 + 0x2b bytes C++
It seems RefCountedBytes data has no data. If data size is 0, accessing
front
of data would cause crash.
By checking its size, fixes this crash.
BUG=25803
TEST=no crash on startup
Review URL: http://codereview.chromium.org/328037
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
