Comment #5 on issue 25915 by [email protected]: Data races in BookmarkModelWorker http://code.google.com/p/chromium/issues/detail?id=25915
syncapi_event_.Signal() can't be moved above "syncapi_has_shutdown_ = true" since Signal() implies a release-barrier (it does system call). However, an opposite thing can happen: some code before "syncapi_has_shutdown_ = true" can be moved after it by the optimizer. If OnSyncerShutdownComplete() happens to be inlined, this may harmful. I think manual reset doesn't make much difference in the scenario I've mentioned in my previous comment if the above optimization happens. Regarding "state_", I'll take a closer look tomorrow. > Also, this class exists... If BookmarkModelWorker is not used in the Chromium itself, that's fine. Otherwise, I'd rather be sure the synchronization is correct. For example, we've known about http://crbug.com/18488 in early August. But nobody cared much until we proved it was the cause of a top crasher... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
