Comment #7 on issue 25542 by [email protected]: model associator can
accidentally believe LoadAssociations was successful, but it wasn't
http://code.google.com/p/chromium/issues/detail?id=25542
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30441
------------------------------------------------------------------------
r30441 | [email protected] | 2009-10-28 23:48:15 -0700 (Wed, 28 Oct 2009)
| 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/model_associator.cc?r1=30441&r2=30440
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_unittest.cc?r1=30441&r2=30440
Make some improvements to sync model associator:
- Fail the load assocications if there the total number of
nodes in the bookmark model and the sync model don't match
(issue: 25542)
- Add a bookmark id index and use that during load assocications
instead of calling BookmarkModel::GetNodeByID since the latter
traverses the entier tree in DFS order until it finds the node
with the given ID.
- Add a unit test that would exercise the new model associator
load associations behavior.
BUG=25542
TEST=Unit test added.
Review URL: http://codereview.chromium.org/337037
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
