Comment #7 on issue 24827 by [email protected]: bookmarks / bookmark
folder icons overlap with chevron on the bookmark bar
http://code.google.com/p/chromium/issues/detail?id=24827
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30684
------------------------------------------------------------------------
r30684 | [email protected] | 2009-11-01 16:12:26 -0800 (Sun, 01 Nov 2009) |
32 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_constants.h?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h?r1=30684&r2=30683
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=30684&r2=30683
Add the "Other bookmarks" button on the right of the bookmark bar.
Lots of fixes to deal better with the floating bar on the
NTP (e.g. chevron resize, chevron enabling only when there is
overflow, ...)
Move layoutSubviews logic from bookmark_bar_toolbar_view to
bookmark_bar_controller to better honor MVC.
BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018
TEST=Lots of moves:
New browser with no bookmarks.
Go to New Tab Page. Show Bookmark Bar.
See "Other Bookmarks" button on right.
Do NOT see chevron.
Hover over and click on Other Bookmarks to be sure it doesn't draw out of
bounds.
Disable bookmark bar (so it is now floating).
Repeat hover/click test.
Enable (so now attached).
Add bookmarks until chevron shows up.
Repeat hover/click test with chevron and Other Bookmarks.
Make browser wider and thinner; each time repeat hover/click test.
Detach bookmark bar (so floating on NTP).
Make browser wider and thinner; each time repeat hover/click test.
Carefully make browser wider/thinner so chevron appears/disappears.
Make sure chevron never overlaps a bookmark.
With chevron visible, quit & relaunch. Make sure chevron visible.
With chevron NOT visible, quit & relaunch. Make sure chevron not visible.
Review URL: http://codereview.chromium.org/348017
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
