Comment #16 on issue 25693 by [email protected]: Crash in ExtensionActionState::PaintBadge http://code.google.com/p/chromium/issues/detail?id=25693
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30900
------------------------------------------------------------------------
r30900 | [email protected] | 2009-11-03 16:32:11 -0800 (Tue, 03 Nov 2009)
| 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/gfx/font.h?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/gfx/font_mac.mm?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/gfx/font_skia.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/gfx/font_win.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/resource_bundle.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/app/resource_bundle.h?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/chrome/browser/views/first_run_bubble.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/chrome/browser/views/options/languages_page_view.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/chrome/browser/views/options/options_group_view.cc?r1=30900&r2=30899
M
http://src.chromium.org/viewvc/chrome/branches/229/src/chrome/common/extensions/extension_action.cc?r1=30900&r2=30899
Merge 30631 - Fix up extension badge text drawing.
Fall abck to the system default font if the preferred font isn't available.
Also, only create the SkPaint struct once, not on every paint.
Also, make some more things const.
BUG=25693
TEST=badge still looks good, that crash goes away
Review URL: http://codereview.chromium.org/341045
[email protected]
Review URL: http://codereview.chromium.org/351031
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
