Comment #10 on issue 17949 by [email protected]: Hebrew: F11 is shown
as F1 plus ellipsis on "Exit full screen (F11)" animation
http://code.google.com/p/chromium/issues/detail?id=17949
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30863
------------------------------------------------------------------------
r30863 | [email protected] | 2009-11-03 13:01:04 -0800 (Tue, 03 Nov 2009)
| 22 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/label.cc?r1=30863&r2=30862
Fullscreen Exit Bubble should not elide its label.
When drawing a Label it is important to adjust for
RTL not just when drawing, but also when computing
the size of the string.
Before this change, we'd compute using Font::GetStringWidth
(which uses ::GetTextExtentPoint32 *without* adjusting
the string for RTL) and draw using DoDrawText (which
adjusts for RTL and then draws using ::DrawText).
After this change, we now use SizeStringInt for
computing (so we now compute and draw using the
same ::DrawText function, thereby adjusting the
string for RTL in both cases).
BUG=17949
TEST=Run chrome with --lang=he, press F11 and
the string in the bubble at the top should not
be elided.
Review URL: http://codereview.chromium.org/354014
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
