Comment #9 on issue 25957 by [email protected]: View and its sub menus
should stay on clicking the option "Text Encoding"
http://code.google.com/p/chromium/issues/detail?id=25957
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30836
------------------------------------------------------------------------
r30836 | [email protected] | 2009-11-03 10:53:04 -0800 (Tue, 03 Nov
2009) | 12 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/MainMenu.xib?r1=30836&r2=30835
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=30836&r2=30835
Mac: fix Text Encoding menu/submenu
(1) Clicking on the Text Encoding menu item should display the submenu, not
try to execute a nonexistent command.
(2) The Text Encoding menu item shouldn't be disabled, but instead the
submenu's contents (so that the submenu is always visible). See Apple's HIG:
<http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>.
Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text
Encoding menu item.
BUG=25957,26593
TEST=Check that the Text Encoding submenu is always available, with its
contents disabled on the NTP (for example) and enabled (and working) on a
normal web page. Check that clicking (and releasing) on the Text Encoding
menu item itself shows the submenu.
Review URL: http://codereview.chromium.org/345050
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
