Comment #2 on issue 26012 by [email protected]: Remove all Chrome  
Frame #defines from non-installer Chrome components.
http://code.google.com/p/chromium/issues/detail?id=26012

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=31015

------------------------------------------------------------------------
r31015 | [email protected] | 2009-11-04 14:18:57 -0800 (Wed, 04 Nov  
2009) | 16 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/client_util.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run_win.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sandbox_policy.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/utility_process_host.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/setup_main.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/browser_distribution.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/browser_distribution.h?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/install_util.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/install_util.h?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/util_constants.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/util_constants.h?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_frame_automation.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_launcher.cc?r1=31015&r2=31014
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=31015&r2=31014

Continue to remove CHROME_FRAME_BUILD define from code that goes into  
chrome.dll. This reworks the browser distribution code to use the  
ChromeFrameBrowserDistribution iff --chrome-frame is present on the command  
line.

Also,

* At startup, chrome.exe now uses the BrowserDistribution code to determine  
where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to  
uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to  
chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the  
installer.


BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds  
built without 'branding'='Chrome' now install correctly.


Review URL: http://codereview.chromium.org/345021
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to