Comment #5 on issue 26137 by [email protected]: CRASH Infobar close
button versus JavaScript close
http://code.google.com/p/chromium/issues/detail?id=26137
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31183
------------------------------------------------------------------------
r31183 | [email protected] | 2009-11-05 16:50:29 -0800 (Thu, 05 Nov 2009)
| 27 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.mm?r1=31183&r2=31182
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=31183&r2=31182
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view.h?r1=31183&r2=31182
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.h?r1=31183&r2=31182
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_mac.mm?r1=31183&r2=31182
[Mac] Delay TabContents::Close() when event-tracking.
The close is delayed until the main event loop restarts.
Renderers can cause UI state changes which can badly break
event-tracking loops. The basic pattern is "Run JavaScript to close
window after a timeout, and start event-tracking loop and keep it
going across the timeout." Things crash when UI elements attempt to
refer to freed objects. Examples:
- Last tab in a window closes while dragging the window.
- Last tab in a window closes while bookmark bar context menu visible.
- Last tab in a window closes while download shelf context menu visible.
- Tab closes while dragging a link over the tab.
- Tab closes while dragging a link from the tab.
- Tab closes while back/forward context menu is open.
- Tab closes while click-hold in the tab's close button.
- Tab closes while closing info bar.
- Tab closes while tab context menu is visible.
- Probably more I'm not aware of.
Supersedes (and reverts) previous fix for issues 25462 and 25465.
BUG=25462, 25463, 25465, 26135, 26136, 26137, 25467
TEST=See bugs for repro cases.
Review URL: http://codereview.chromium.org/362013
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
