Comment #18 on issue 25099 by [email protected]: "Bookmark All Tabs"
not working (Implement BrowserEditor::Show for NEW_FOLDER)
http://code.google.com/p/chromium/issues/detail?id=25099
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31200
------------------------------------------------------------------------
r31200 | [email protected] | 2009-11-05 19:24:29 -0800 (Thu, 05 Nov
2009) | 10 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkAllTabs.xib
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkEditor.xib?r1=31200&r2=31199
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h?r1=31200&r2=31199
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm?r1=31200&r2=31199
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm?r1=31200&r2=31199
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=31200&r2=31199
Implement Bookmark All Tabs... Added an abstraction of
BookmarkEditorController called BookmarkEditorBaseController, from which
BookmarkEditorController and the new BookmarkAllTabsController derive. The
bookmark/folder name, URL and OK button now use bindings/KVO. Added
BookmarkAllTabs.xib which is nearly identical to BookmarkEditor.xib.
Changed unit test since an empty bookmark name is now acceptable. Added
unit test for the Bookmark All Tabs...
BookmarkEditor.xib changes: Removed the bookmark name and url as outlets
and instead bound their values to controller's displayName and displayURL
respectively. Bound the OK button enabling to the controller's okEnabled.
BUG=25099
TEST=Open two or more tabs. Bring up a contextual menu by control-clicking
on one of the tabs. Choose the Bookmark All Tabs... menu item. A dialog
will be presented in which you can type a folder name and select the parent
folder in which the new folder will be placed. By default, the most
recently touched folder will be selected as the parent. Click OK. Now
check to parent folder to see that the newly created folder has been added
and then check within that folder to see that the open tabs have been added.
Perform the above operation again only this time choose the Bookmark All
Tabs... menu item found in the Bookmarks menu.
Review URL: http://codereview.chromium.org/357005
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
