Comment #14 on issue 12126 by [email protected]: Implement alert(), prompt(), and confirm() for extensions http://code.google.com/p/chromium/issues/detail?id=12126
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31204
------------------------------------------------------------------------
r31204 | [email protected] | 2009-11-05 20:08:54 -0800 (Thu, 05 Nov 2009) |
8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_modal_dialog.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_modal_dialog.h?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_modal_dialog_gtk.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=31204&r2=31203
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jsmessage_box_client.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jsmessage_box_handler.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/jsmessage_box_handler.h?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/jsmessage_box_dialog.cc?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/jsmessage_box_dialog.h?r1=31204&r2=31203
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=31204&r2=31203
Implement window.alert() and its cousins for extensions.
Second try, now with fixed observer.
BUG=12126
TEST=put a window.prompt() in a background page, a browser action, and a
page action.
Make sure it gets the result back correctly. Also make sure it still works
when
called from a web page.
Review URL: http://codereview.chromium.org/373006
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
