Updates:
Status: Fixed
Comment #2 on issue 27664 by [email protected]: Crash @
UrlmonUrlRequest::EndRequestInternal
http://code.google.com/p/chromium/issues/detail?id=27664
New Revision: 31970
Log:
Merge 31792 - The ChromeFrameAutomationClient class needs to be refcounted
as it
implements the PluginRequestHandler
interface which is maintained by individual requests which can outlive the
active
document/activex instances.
I ran into a crash where UrlmonUrlRequest was calling into an invalid
PluginRequestHandler pointer which
had been destroyed just before.
We also need to ensure that UrlmonUrlRequest and ChromeFrameActiveXBase
select the
multi threaded model as
AddRef/Release can be invoked from multiple threads.
I also removed the CleanupAsyncRequests function in
ChromeFrameAutomationClient and
moved all the code to CleanupRequests, which ensures that we treat
synchronous
and asynchronous requests similarly.
There are instances where an automation client instance is created and
destroyed
without being initialized which causes a spurious assert to fire in the
Uninitialize
function. I added a check in the Uninitialize function to return if the
state is
uninitialized.
Bug=none
Review URL: http://codereview.chromium.org/386014
[email protected]
Review URL: http://codereview.chromium.org/385111
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
