Comment #2 on issue 27529 by [email protected]: 'Delete' and 'Rename'
options are disabled for BMB folder
http://code.google.com/p/chromium/issues/detail?id=27529
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32029
------------------------------------------------------------------------
r32029 | [email protected] | 2009-11-15 11:26:33 -0800 (Sun, 15 Nov 2009) |
22 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=32029&r2=32028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=32029&r2=32028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=32029&r2=32028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=32029&r2=32028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm?r1=32029&r2=32028
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm?r1=32029&r2=32028
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=32029&r2=32028
Fix "open all" on a folder node to open only 'marks in that folder,
not ALL all. Make Delete and Rename enabled for folder context menu
(but disabled for "Other Bookmarks").
nib changes (related to the context menus):
- Telegate is the bookmark bar controller.
- Switched type from NSMenu to BookmarkMenu.
TEST=New window. Create folder "empty" with nothing in it. Create
folder "two" with 2 bookmarks in it. Create a final bookmark in the
top level of the bar.
Context menu (right click) over all folders.
Make sure Delete and Rename enabled for folders but not "Other Bookmarks".
Make sure "Open All" (and friends) disabled over "empty", enabled
over "two".
"Open All" on "two" --> see 2 opened.
"Open All" on the bar itself --> see 3 opened.
Ditto for "Open all in new window" and "open all in incognito window".
Create a new window. In new window, make sure folders have context menus.
BUG=http://crbug.com/27522, http://crbug.com/27529
Review URL: http://codereview.chromium.org/391046
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
