Comment #56 on issue 20511 by [email protected]: Crash -
AutocompletePopupModel::URLsForCurrentSelection(unsigned int *,bool *,GURL
*)
http://code.google.com/p/chromium/issues/detail?id=20511
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31649
------------------------------------------------------------------------
r31649 | [email protected] | 2009-11-10 21:42:41 -0800 (Tue, 10 Nov
2009) | 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_contents_view.h?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_gtk.h?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.cc?r1=31649&r2=31648
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/autocomplete/autocomplete_popup_win.h?r1=31649&r2=31648
Avoid inconsistent state (leading to checkfailures) due to Windows
minimize/restore functionality hiding and showing the autocomplete dropdown
outside of the awareness of the controller.
Instead, this switches to the simpler model of just creating a new HWND
when we want to show the dropdown, and destroying it when we want to close
it. Happily, this also seems to save quite a bit of code.
BUG=20511
TEST=Type a character in the omnibox, minimize the window, and restore it.
The dropdown should have disappeared.
Review URL: http://codereview.chromium.org/391011
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
