Comment #3 on issue 25905 by [email protected]: Optimize page
scrolling in the presence of animating regions
http://code.google.com/p/chromium/issues/detail?id=25905
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32496
------------------------------------------------------------------------
r32496 | [email protected] | 2009-11-18 21:24:57 -0800 (Wed, 18 Nov 2009)
| 21 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/gfx/rect.h?r1=32496&r2=32495
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_renderer.gypi?r1=32496&r2=32495
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=32496&r2=32495
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/paint_aggregator.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/paint_aggregator.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/paint_aggregator_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.cc?r1=32496&r2=32495
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.h?r1=32496&r2=32495
Refactors RenderWidget to extract a PaintAggregator class.
After this change, I plan on changing the PaintAggregator algorithm.
Some things to note:
1- Previously, it was possible to send overlapping ViewHostMsg_PaintRect and
ViewHostMsg_ScrollRect messages. This happened when scrolling a page since
the
scrollbar would need to be repainted while the contents of the page are
being
scrolled. With this CL, this overlapping behavior is a bit more explicit.
2- There was a TODO about view_size clipping that I've eliminated. I was
able
to eliminate it because I realized that it is correct to clip the rects
passed
by didInvalidateRect and didScrollRect to the size of the RenderWidget.
Apparently WebKit can sometimes invalidate regions outside the view.
R=brettw
BUG=25905
TEST=none
Review URL: http://codereview.chromium.org/403005
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
