Comment #2 on issue 12710 by [email protected]: Implement better test  
isolation, to make them more solid and easier to debug
http://code.google.com/p/chromium/issues/detail?id=12710

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=32507

------------------------------------------------------------------------
r32507 | [email protected] | 2009-11-19 01:11:39 -0800 (Thu, 19 Nov  
2009) | 17 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/at_exit.h?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/at_exit_unittest.cc?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/lazy_instance.cc?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/lazy_instance.h?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/lazy_instance_unittest.cc?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/singleton_unittest.cc?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/test/run_all_unittests.cc?r1=32507&r2=32506
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/test/test_suite.h?r1=32507&r2=32506

Isolate tests by running AtExit callbacks between them.

For now, this is only for base_unittests. The plan is to enable
it for all unit tests. This should finally fix mysterious
problems cause by Singletons surviving after one test etc.

This change also adapts LazyInstance so that it can be reused
after being destroyed. It is used very frequently, for example
each time a MessageLoop is used. It is also worth noting that
we had some problems in the past related to the MessageLoop
being destroyed and re-instantiated in the same test executable.
This patch should also fix that.

TEST=none
BUG=12710

Review URL: http://codereview.chromium.org/372057
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to