Comment #8 on issue 25266 by [email protected]: [sync cleanup fixit]
untangle SyncerSession et al
http://code.google.com/p/chromium/issues/detail?id=25266
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32732
------------------------------------------------------------------------
r32732 | [email protected] | 2009-11-20 19:29:52 -0800 (Fri, 20 Nov 2009) |
14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/all_status.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/all_status.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/apply_updates_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/apply_updates_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/apply_updates_command_unittest.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/build_and_process_conflict_sets_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/build_commit_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/build_commit_command.h?r1=32732&r2=32731
D /trunk/src/chrome/browser/sync/engine/client_command_channel.h
D /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.cc
D /trunk/src/chrome/browser/sync/engine/conflict_resolution_view.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/conflict_resolver.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/conflict_resolver.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/download_updates_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/download_updates_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/get_commit_ids_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/get_commit_ids_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/model_changing_syncer_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/post_commit_message_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/post_commit_message_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/process_commit_response_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/process_commit_response_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/process_updates_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/process_updates_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/resolve_conflicts_command.h?r1=32732&r2=32731
D /trunk/src/chrome/browser/sync/engine/sync_cycle_state.h
D /trunk/src/chrome/browser/sync/engine/sync_process_state.cc
D /trunk/src/chrome/browser/sync/engine/sync_process_state.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_end_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_end_command.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_proto_util.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_proto_util.h?r1=32732&r2=32731
D /trunk/src/chrome/browser/sync/engine/syncer_session.h
D /trunk/src/chrome/browser/sync/engine/syncer_status.cc
D /trunk/src/chrome/browser/sync/engine/syncer_status.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_thread.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_thread.h?r1=32732&r2=32731
D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.cc
D /trunk/src/chrome/browser/sync/engine/syncer_thread_timed_stop.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_thread_unittest.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_types.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_unittest.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/update_applicator.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/update_applicator.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/verify_updates_command.cc?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/verify_updates_command.h?r1=32732&r2=32731
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/session_state.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/session_state.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/status_controller.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/status_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/status_controller_unittest.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/sync_session.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/sync_session.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/sync_session_context.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sessions/sync_session_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/blob.h?r1=32732&r2=32731
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=32732&r2=32731
Add browser_sync 'sessions' to relieve SyncCycleState, SyncProcessState,
SyncerSession,
SyncerStatus, and ConflictResolutionView of duty.
Main impact is factors all status munging to 'StatusController', adds
SyncSessionContext
to wrap various engine parts needed by different components, removes
duplicated methods by a
factor of ~3 making it easier to reason about, and adds a 'Controller' to
the session object to
give a way to delegate session-global (i.e affecting any session)
occurrences such as throttling.
Also adds testing for 'HasMoreToSync' and other session related code.
BUG=25266
TEST=SyncSessionTest(added), StatusControllerTest(added)
various sync_unit_tests in this CL
Review URL: http://codereview.chromium.org/386030
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
