Comment #1 on issue 28296 by [email protected]: ChromeFrames IE Host
network stack implementation should not automatically follow redirects.
http://code.google.com/p/chromium/issues/detail?id=28296
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32896
------------------------------------------------------------------------
r32896 | [email protected] | 2009-11-23 17:21:35 -0800 (Mon, 23 Nov 2009)
| 18 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/url_request_automation_job.cc?r1=32896&r2=32895
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/urlmon_url_request.cc?r1=32896&r2=32895
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/urlmon_url_request.h?r1=32896&r2=32895
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_headers.cc?r1=32896&r2=32895
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_headers.h?r1=32896&r2=32895
ChromeFrame's host network stack implementation for IE full tab mode
implicitly follows redirects.
When Chrome receives a notification about a redirect it also attempts to
follow the redirect request. While
this works in most cases, some sites actually returned an error for the
second request initiated by Chrome.
Fix is to abort the request in urlmon, when we receive a notification about
a redirect. I also fixed the
IsRedirectResponse function in the UrlRequestAutomationJob class to only
treat 301, 302, 303 and 307 as
redirect codes on the same lines as the default http job.
Test=covered by existing network tests.
I also verified that
http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL.
Fixes http://code.google.com/p/chromium/issues/detail?id=28296
Bug=28296
Review URL: http://codereview.chromium.org/402107
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
