Comment #2 on issue 28994 by [email protected]: Crash -  
net::HttpCache::ConvertWriterToReader
http://code.google.com/p/chromium/issues/detail?id=28994

Now I remember looking at this crash before...

Basically, this code receives a valid entry_:

int HttpCache::Transaction::DoPartialCacheReadCompleted(int result) {
   partial_->OnCacheReadCompleted(result);

   if (result == 0) {  // End of file.
     if (partial_.get() && mode_ == READ_WRITE) {
       // We need to move on to the next range.
       result = ContinuePartialCacheValidation();
       if (result != OK)
         // Any error was already handled.
         return result;
       cache_->ConvertWriterToReader(entry_);    <- no entry_
     }
     cache_->DoneReadingFromEntry(entry_, this);
     entry_ = NULL;
   }

so ContinuePartialCacheValidation() has to delete the entry_. For that to  
happen,
partial_->PrepareCacheValidation() has to say we are not done yet and  
ReadFromEntry()
has to return 0 again (and that makes sense, because it already did it).

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to