Comment #2 on issue 28154 by [email protected]: Mac: interaction of
pinned tabs and dragging needs work
http://code.google.com/p/chromium/issues/detail?id=28154
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=33455
------------------------------------------------------------------------
r33455 | [email protected] | 2009-12-01 09:57:12 -0800 (Tue, 01 Dec
2009) | 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=33455&r2=33454
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.mm?r1=33455&r2=33454
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h?r1=33455&r2=33454
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm?r1=33455&r2=33454
Mac: change tab change notifications to pass full TabChangeType.
This makes the Mac code better parallel that on other platforms. It will
also be needed to make the "glow" animation for (unselected,
title-changing) pinned tabs work. (I have a mostly-working patch which does
the glow, but it's horribly hacky and to get it to completely work would
either involve much more hackiness or significant refactoring. That's why
the glow is not part of this CL.)
Also: prevent changes in background tabs (e.g., loading finished) from
killing any current bookmark bar animation. Still to do on this front (part
of issue 27693): be smarter about bookmark bar updates in the selected tab.
BUG=28154, 27693
TEST=Load lots of (slow-loading) pages in background tabs while pressing
Shift-Cmd-B repeatedly; make sure changes in background (unselected) tabs
don't cancel the animation.
Review URL: http://codereview.chromium.org/449056
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
