Comment #1 on issue 29033 by [email protected]: Race condition in  
UrlmonUrlRequest EndRequest and OnStopBinding leading to crash.
http://code.google.com/p/chromium/issues/detail?id=29033

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=33551

------------------------------------------------------------------------
r33551 | [email protected] | 2009-12-01 22:06:07 -0800 (Tue, 01 Dec 2009)  
| 12 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/urlmon_url_request.cc?r1=33551&r2=33550
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/urlmon_url_request.h?r1=33551&r2=33550

Fix a crash caused by a race condition between the time the  
UrlmonUrlRequest::EndRequestInternal task
executing and the OnStopBinding function getting called by Urlmon. If our  
task executes first we essentially
operate on an invalid object.

Fixes http://code.google.com/p/chromium/issues/detail?id=29033

Added a comment to the EndRequest function indicating that it is invalid to  
access any members after it
is called. Added a helper function to release the bindings and revoke the  
bind status callback.

Bug=29033

Review URL: http://codereview.chromium.org/456013
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to