Comment #1 on issue 28609 by [email protected]: HTML dialogs need to
share the same tab contents delegate across all platforms
http://code.google.com/p/chromium/issues/detail?id=28609
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=33752
------------------------------------------------------------------------
r33752 | [email protected] | 2009-12-03 15:54:45 -0800 (Thu, 03 Dec 2009)
| 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/html_dialog_window_controller.h?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/html_dialog_window_controller.mm?r1=33752&r2=33751
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/html_dialog_tab_contents_delegate_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/html_dialog_gtk.cc?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/html_dialog_gtk.h?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/html_dialog_view.cc?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/html_dialog_view.h?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=33752&r2=33751
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=33752&r2=33751
Created HtmlDialogTabContentsDelegate, which encapsulates the
TabContentsDelegate behavior for HTML dialogs. Made all three
implementations (gtk, win32, and cocoa) use it.
This also makes HTML dialogs not tied to a Browser instance. Also, unlike
the current behavior, any links followed from an HTML dialog box will be
opened in a non-incognito browser, even if the HTML dialog was launched
from an incognito browser. According to beng, this is okay.
BUG=28609
TEST=unittests, manual testing on linux/windows/os x with sync setup wizard
Review URL: http://codereview.chromium.org/441011
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
