Comment #4 on issue 25625 by [email protected]: Implement Chrome  
Keyboard Access for all toolbars.
http://code.google.com/p/chromium/issues/detail?id=25625

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=33793

------------------------------------------------------------------------
r33793 | [email protected] | 2009-12-03 21:32:25 -0800 (Thu, 03 Dec 2009) |  
13 lines
Changed paths:
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/accessible_toolbar_view.cc
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/accessible_toolbar_view.h
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view.cc?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view.h?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/detachable_toolbar_view.h?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.h?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/button/menu_button.cc?r1=33793&r2=33792
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/button/menu_button.h?r1=33793&r2=33792

Implement keyboard access between bookmarks and main toolbar.

Allow ALT+SHIFT+T and TAB to traverse between bookmarks bar and main  
toolbar, same thing goes for SHIFT+TAB. Once any toolbar is focused, the  
arrow keys are used to traverse its children views.

Any toolbar that needs to be traversable needs to  
extend "AccessibleToolbarView", that class will deal with all the toolbar  
accessibility needs such as handling ESC, Left/Right arrows, Enter, Drop  
downs, and traversals with Tab/Shift+Tab.

There is one abstract method that the views who are extending this would  
need to implement if needed which allows the toolbar to skip views that are  
being traversed:
  bool IsAccessibleViewTraversable(views::View* view)

BUG=25625
TEST=Test to see if the main toolbar and bookmarks bar is traversable.

Review URL: http://codereview.chromium.org/333010
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to