Updates:
Status: Fixed
Comment #10 on issue 2635 by [email protected]: Unit tests should not
generate actual DNS queries
http://code.google.com/p/chromium/issues/detail?id=2635
I think this can be safely closed as Fixed. Grep shows this:
$ git grep AllowDirectLookup
chrome/test/live_sync/live_bookmarks_sync_test.cc:
resolver->AllowDirectLookup("*.google.com");
chrome/test/unit/chrome_test_suite.h: // net::RuleBasedHostResolverProc
and its AllowDirectLookup method.
net/base/host_resolver_impl_unittest.cc:
resolver_proc->AllowDirectLookup("*");
net/base/host_resolver_impl_unittest.cc:
resolver_proc->AllowDirectLookup("*");
net/base/host_resolver_impl_unittest.cc:
resolver_proc->AllowDirectLookup("*");
net/base/mock_host_resolver.cc:void
RuleBasedHostResolverProc::AllowDirectLookup(
net/base/mock_host_resolver.h: void AllowDirectLookup(const std::string&
host);
And the lookups in host_resolver_impl_unittest.cc are just IP addresses. I
have verified that net_unittests stil pass with network access turned
off (just physically disconnected the network).
Feel free to re-open if you think something still needs to be fixed.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
