Comment #10 on issue 22646 by [email protected]: code share page and tools menus http://code.google.com/p/chromium/issues/detail?id=22646
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34179
------------------------------------------------------------------------
r34179 | [email protected] | 2009-12-09 11:56:30 -0800 (Wed, 09 Dec
2009) | 4 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/app/menus/simple_menu_model.h?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=34179&r2=34178
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.mm
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller_unittest.mm
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=34179&r2=34178
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_menu_model.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_menu_model.h
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_menu_model_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=34179&r2=34178
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=34179&r2=34178
Share the code that builds the page menu in a common model, make Mac and
Win use it. Implement a mac menu controller that takes this model and
generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since
it's now created in code.
BUG=22646
TEST=page menu should work as before
Review URL: http://codereview.chromium.org/465130
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
