Comment #8 on issue 24885 by [email protected]: DCHECK is not friendly
to googletest's "death tests" on Windows
http://code.google.com/p/chromium/issues/detail?id=24885
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34273
------------------------------------------------------------------------
r34273 | [email protected] | 2009-12-10 12:33:02 -0800 (Thu, 10 Dec
2009) | 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/cancellation_flag_unittest.cc?r1=34273&r2=34272
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/test/test_suite.h?r1=34273&r2=34272
Force failing CHECK/DCHECKs to end the process on Windows.
The current implementation of Windows-only hook simply calls FAIL.
According to http://code.google.com/p/googletest/issues/list?cursor=234
it is a misuse of FAIL macros (it may not shut down the process).
As a result, it was impossible to write death tests on windows.
BUG=24885
Review URL: http://codereview.chromium.org/482001
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
