Comment #14 on issue 29914 by [email protected]: DNS queries not
forwarded through SOCKS v5 proxies
http://code.google.com/p/chromium/issues/detail?id=29914
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34903
------------------------------------------------------------------------
r34903 | [email protected] | 2009-12-17 16:24:37 -0800 (Thu, 17 Dec 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction.cc?r1=34903&r2=34902
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=34903&r2=34902
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks5_client_socket.cc?r1=34903&r2=34902
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks5_client_socket.h?r1=34903&r2=34902
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks5_client_socket_unittest.cc?r1=34903&r2=34902
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket_stream/socket_stream.cc?r1=34903&r2=34902
When talking to a SOCKS v5 proxy, default to sending addresses as raw
domains rather than IP addresses.
Before, we would default to client-side DNS resolution (sending IP
addresses to the proxy) for both v4 and v5. However if you are using a v5
server, it is most likely that you want to do the resolves on the
proxy-side. And in fact if you are using a SOCKS 5 proxy to anonymize your
browsing, you definitely don't want that as the default policy.
Embedders of the network stack can select the alternate policy by passing a
non-NULL Host resolver into SOCKS5ClientSocket.
BUG=29914
TEST=HttpNetworkTransactionTest.SOCKS5_HTTP_GET,
HttpNetworkTransactionTest.SOCKS5_SSL_GET
Review URL: http://codereview.chromium.org/507033
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
