Comment #1 on issue 30169 by [email protected]: Broadcast  
notifications when multiple autofill items are removed
http://code.google.com/p/chromium/issues/detail?id=30169

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=34889

------------------------------------------------------------------------
r34889 | [email protected] | 2009-12-17 14:45:27 -0800 (Thu, 17 Dec 2009)  
| 10 lines
Changed paths:
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_change.cc
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_change.h?r1=34889&r2=34888
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_entry.cc
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/autofill_entry.h?r1=34889&r2=34888
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/web_data_service.cc?r1=34889&r2=34888
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/web_database.cc?r1=34889&r2=34888
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/web_database.h?r1=34889&r2=34888
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/webdata/web_database_unittest.cc?r1=34889&r2=34888
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=34889&r2=34888

Return a list of changed from WebDatabase::RemoveFormElementsAddedBetween()
This changes add a list of AutofillChange out parameter to the  
RemoveFormElementsAddedBetween() method in order to communicate exactly  
what happened to the caller.  This method may only update some autofill  
entries (by removing use timestamps that fall in the specified time range)  
or completely remove the autofill entry (if all the use timestamps fall  
between the specified time range).  For sync, we need to know the  
difference.

This change also required some new testing method on WebDatabase to make it  
possible to add new autofill entries with specific timestamps.  This is  
needed to create a reliable test that requires entries to be added at  
different times.  If there is a better way to do this, please let me know.

The next change will add the notifications to the WebDataService.

BUG=30169

Review URL: http://codereview.chromium.org/506047
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to