Comment #2 on issue 29591 by [email protected]: Combine  
ViewHostMsg_{Paint,Scroll}Rect messages
http://code.google.com/p/chromium/issues/detail?id=29591

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=34951

------------------------------------------------------------------------
r34951 | [email protected] | 2009-12-18 07:37:08 -0800 (Fri, 18 Dec 2009)  
| 19 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/backing_store.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/backing_store_mac.mm?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/backing_store_win.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/backing_store_x.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/mock_render_process_host.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/mock_render_process_host.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_process_host.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_unittest.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/test/test_render_view_host.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.cc?r1=34951&r2=34950
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.h?r1=34951&r2=34950

Combine ViewHostMsg_{Paint,Scroll}Rect into one IPC.

The combined IPC means that scrolling only requires one transport DIB  
instead
of two.  Previously, we'd use one in the ScrollRect IPC to pass up the  
pixels
for the exposed region, and then we'd use a second one in the PaintRect IPC  
to
pass up the pixels for the updated scroll bar rendering.  Now all paints are
done using a single transport DIB.

Optimize RenderWidgetHostViewWin::OnPaint to only paint the damaged regions.
This means calling GetUpdateRgn and GetRegionData to enumerate the list of
damage rects.  Then only those rects are copied from the backing store.

The same optimization is not done for Linux or Mac yet.

R=brettw
BUG=29591
TEST=none

Review URL: http://codereview.chromium.org/506013
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to