Comment #9 on issue 26154 by [email protected]: Switching tab after
window resize fails with assertion
http://code.google.com/p/chromium/issues/detail?id=26154
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35220
------------------------------------------------------------------------
r35220 | [email protected] | 2009-12-23 09:14:28 -0800 (Wed, 23 Dec 2009)
| 12 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tab_contents/tab_contents_view_gtk.cc?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host.cc?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host.h?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_gtk.cc?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_gtk.h?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_win.cc?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_win.h?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_wrapper.h?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native_control_gtk.cc?r1=35220&r2=35219
M
http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/widget_gtk.cc?r1=35220&r2=35219
Fix crash/leak issue in native_view_host_gtk.cc.
* There are two path to NativeViewDetaching and we need to handle them
differently.
1) Via gtk destroy signal. In this case, we should not try to remove the
native view from parent because it's being deleted.
2) Through NativeViewHost::Detach(). In this case we need to remove the
native view from parent because we added it to parent in
NativeViewAttached().
* Fix NativeControlGtk not to destroy the native view because it's now
destoryed by NativeViewHostGtk.
* Fixed TabContentViewGtk so that it owns the nativew view. The native
view was destroyed when Detached.
* Added more checks so that test can catch regression.
BUG=26154
TEST=The same procedure in bug should now pass. I added several checks that
lead tests to fail if this problem exists.
Review URL: http://codereview.chromium.org/510004
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
