Comment #12 on issue 17368 by [email protected]: There should be a way to dock DevTools window. http://code.google.com/p/chromium/issues/detail?id=17368
@thakis: I just checked latest continuous/mac/2010-01-03/35448/ and devtools works just fine. We sometimes need a clean build so that proper js files are compiled into the binary (we fetch them as resources when injecting scripts). The code responsible for docking/undocking is located here: http://www.google.com/codesearch/p? hl=en#h0RrPvyPu- c/chrome/browser/debugger/devtools_window.cc&q=SetDocked&exact_package=http://src.chromium.org/s vn/trunk/src&sa=N&cd=1&ct=rc&l=131. But essentially it is just calling into browser window's UpdateDevTools. I can see that you are fixing it in the right place for mac in your patch. Yes, you did find the right ifdef that overrides docking settings for Mac, implementing UpdateDevTools + removing this workaround should make things work. FYI: InspectorClientImpl is upstream, single process version of web inspector client, we don't use it in Chromium. There is a plan to replace it with two clients working in inspected and inspector processes. Anyways, please take another look at http://codereview.chromium.org/151150 and http://codereview.chromium.org/149675 as referenced in this bug. The work on docked/undocked devtools was structured in a way that it was implemented in general first and then needed to be enabled for platforms in their specifics. These changes enabled devtools for windows and linux respectively. In both cases, devtools contents was added into a separate tabcontentscontainer right into the browser window, outside browser's tabstrip. We were not going to add support for drag'drop devtools into a separate window. Furthermore, we wanted devtools to look like an app, not a page. We've achieved that on Windows and Linux, while Mac still shows the location bar (should not). Thanks for looking into it, I miss this feature too! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs
