Comment #17 on issue 21541 by [email protected]: Implement shipping privacy blacklists in extensions
http://code.google.com/p/chromium/issues/detail?id=21541
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35538
------------------------------------------------------------------------
r35538 | [email protected] | 2010-01-05 10:14:49 -0800 (Tue, 05 Jan
2010) | 16 lines
Changed paths:M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_url_request_context.h?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist.h?r1=35538&r2=35537 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor.h A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_interceptor_unittest.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_listener.h A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_listener_unittest.cc M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_manager.h?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc?r1=35538&r2=35537 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_request_info.h A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_test_util.h M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/privacy_blacklist/blacklist_ui.cc?r1=35538&r2=35537
D /trunk/src/chrome/browser/privacy_blacklist/blocked_response.cc D /trunk/src/chrome/browser/privacy_blacklist/blocked_response.hM http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/privacy_blacklist_block.html?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.cc?r1=35538&r2=35537 M http://src.chromium.org/viewvc/chrome/trunk/src/net/url_request/url_request_unittest.h?r1=35538&r2=35537
Implement delaying resource requests until privacy blacklists are ready.Associate a BlacklistRequestInfo with each URLRequest started by ResourceDispatcherHost so that in various places we get access to the right BlacklistManager (each Profile has its own), and lazily cache a Blacklist::Match.
BlacklistListener controls delaying requests until the privacy blacklist is ready for the request.
BlacklistInterceptor handles substituting real response with a blocking page or blocking image. I've temporarily removed support for unblocking things. It was too hacky.
This change also removes a large block of blacklist-related code from RDH to more focused classes. Should make it a little more readable.
This should also make BlacklistManagerBrowserTest not flaky. TEST=Covered by browser_tests and unit_tests. BUG=21541, 29113 Review URL: http://codereview.chromium.org/501082 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
-- Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs
