Comment #13 on issue 25440 by [email protected]: crash in net::SOCKSClientSocket::DoCallback
http://code.google.com/p/chromium/issues/detail?id=25440

eroman: If the user kills the chrome process, the signal should be
SIGKILL (kill -9 pid) or SIGINT (ctrl-C).  I think SIGABRT is
raised by the abort() function.

I believe the only callers of SOCKSClientSocket::Connect() are
HttpNetworkTransaction::DoSOCKSConnect() and
SocketStream::DoSOCKSConnect().  Is it possible that the following
code in the HttpNetworkTransaction destructor isn't effective
for SOCKSClientSocket?

  if (connection_.is_initialized())
    connection_.socket()->Disconnect();

On the other hand, I suspect that it's the SOCKSClientSocket::Disconnect()
method that's incomplete:

void SOCKSClientSocket::Disconnect() {
  completed_handshake_ = false;
  transport_->Disconnect();
}

I think it should also do something about host_resolver_
if it has a pending host resolution request.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to