Comment #10 on issue 27362 by [email protected]: Extension message catalogs should not be parsed in browser process
http://code.google.com/p/chromium/issues/detail?id=27362
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35547
------------------------------------------------------------------------
r35547 | [email protected] | 2010-01-05 11:46:42 -0800 (Tue, 05 Jan 2010) |
10 lines
Changed paths:M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_file_util.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/sandboxed_extension_unpacker.h?r1=35547&r2=35546 A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/utility_process_host.h?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/chrome.gyp?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.h?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_constants.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_constants.h?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_unittest.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_unpacker.cc?r1=35547&r2=35546 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_unpacker.h?r1=35547&r2=35546 A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension_unpacker_unittest.cc M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/render_messages_internal.h?r1=35547&r2=35546 A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/empty_default_locale A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/empty_default_locale/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/empty_default_locale.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/en_US/messages.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/_locales/sr/messages.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/good_l10n.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/has_default_missing_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/has_default_missing_locales/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/has_default_missing_locales.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_default_locale A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_default_locale/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_default_locale.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file/_locales/en_US/messages.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/invalid_messages_file.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data/_locales/en_US/messages.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_data.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_has_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_has_locales/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_has_locales/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_default_has_locales.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_messages_file A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_messages_file/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_messages_file/_locales/en_US A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_messages_file/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/missing_messages_file.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_l10n A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_l10n/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_l10n.crx A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_locale_data A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_locale_data/_locales A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_locale_data/manifest.json A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/test/data/extensions/unpacker/no_locale_data.crx M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/utility/utility_thread.cc?r1=35547&r2=35546
Merge 32345 - Parse messages.json in ExtensionUnpacker (like we do for manifest) and pass them to sandboxed_extension_unpacker.
Added unittest files for unpacker and sandboxed unpacker.TEST=Try loading any of the unpacker samples added in this CL. They should either pass, or show error and fail.
BUG=27362 Review URL: http://codereview.chromium.org/390019 [email protected] Review URL: http://codereview.chromium.org/526012 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
-- Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs
