Updates:
Status: Fixed
Comment #4 on issue 30786 by [email protected]: Can't delete cookies with
JavaScript and chromeframe
http://code.google.com/p/chromium/issues/detail?id=30786
New Revision: 35769
Log:
Deleting cookies by setting the expires attribute on them with an empty
value would
not work in ChromeFrame
with the host network stack enabled. When we receive a response in the host
browser
(IE) we send over the
response headers which include the Set-Cookie header and a list of cookies
retreived
via the InternetGetCookie
API. We call this API to retrieve the persistent cookies and send them over
to
Chrome.
However this API returns session cookies as well as persistent cookies.
There is no
documented way to return
only persistent cookies from IE. As a result we would end up setting
duplicate
cookies in Chrome, which caused
this issu.e. To workaround this issue when we receive the response in the
url request
automation job which
handles ChromeFrame network requests, we strip out duplicate cookies sent
via
InternetGetCookie.
When a script deletes a cookie we now handle it correctly in IE and set the
data to
an empty string. However
this does not delete the cookie. When such cookies show up in Chrome, we
strip them
out as well.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786
The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to
the
chrome_frame namespace as they
conflict with similar functions in NACL.
Added the DeleteCookie function to the CookieStore interface, which I think
missed
out by oversight.
Bug=30786
Test=Covered by ChromeFrame unit tests. I also added a unit test to test
the newly
added
URLRequestAutomationJob::IsCookiePresentInCookieHeader function
Review URL: http://codereview.chromium.org/518054
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
