Updates:
Cc: [email protected]
Comment #3 on issue 31768 by [email protected]: Disable "Full
Screen" option on wrench menu till it gets implemented.
http://code.google.com/p/chromium/issues/detail?id=31768
I blame pinkerton, the CL <http://codereview.chromium.org/482006>, and most
of
all whoever reviewed that CL.
@pinkerton: It's probably bad that we (might) do nontrivial/different
things in the
BWC's -validateUserInterfaceItem:. Should we refactor? (This isn't so much
about the
full screen menu item, but about cleanliness.) Two possibilities:
1. Move the code for the command-id-triggered items in -
validateUserInterfaceItem: (i.e., the stuff in the switch statement) to
Browser or
something called by it (so that IsCommandEnabled() gives the right answer).
2. Make a method in the BWC which extracts that switch statement, and which
the
app menu's delegate can check. (This is probably easier, but it won't
guarantee that
everyone who queries the Browser will get the right answer.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
